[FFmpeg-devel] [PATCH 1/3] mpeg12dec: validate color space

Michael Niedermayer michael at niedermayer.cc
Sat Jan 7 04:35:56 EET 2017


On Fri, Jan 06, 2017 at 09:43:24PM +0100, Andreas Cadhalpun wrote:
> On 23.12.2016 00:57, Andreas Cadhalpun wrote:
> > Signed-off-by: Andreas Cadhalpun <Andreas.Cadhalpun at googlemail.com>
> > ---
> >  libavcodec/mpeg12dec.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c
> > index 63979079c8..d3dc67ad6a 100644
> > --- a/libavcodec/mpeg12dec.c
> > +++ b/libavcodec/mpeg12dec.c
> > @@ -1470,6 +1470,10 @@ static void mpeg_decode_sequence_display_extension(Mpeg1Context *s1)
> >          s->avctx->color_primaries = get_bits(&s->gb, 8);
> >          s->avctx->color_trc       = get_bits(&s->gb, 8);
> >          s->avctx->colorspace      = get_bits(&s->gb, 8);
> > +        if (!av_color_space_name(s->avctx->colorspace)) {
> > +            av_log(s->avctx, AV_LOG_WARNING, "Invalid color space %d, setting to unspecified\n", s->avctx->colorspace);
> > +            s->avctx->colorspace = AVCOL_SPC_UNSPECIFIED;
> > +        }
> >      }
> >      w = get_bits(&s->gb, 14);
> >      skip_bits(&s->gb, 1); // marker
> > 
> 
> Ping for the series.

i have no real objection to it.
iam used to see these being exported unchanged though so it feels a
bit odd


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Many things microsoft did are stupid, but not doing something just because
microsoft did it is even more stupid. If everything ms did were stupid they
would be bankrupt already.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170107/085e7995/attachment.sig>


More information about the ffmpeg-devel mailing list