[FFmpeg-devel] [PATCH 9/9] boadec: prevent overflow during block alignment calculation

[Ronald S. Bultje]

Hi,

On Sun, Jan 29, 2017 at 7:37 PM, Andreas Cadhalpun <
andreas.cadhalpun at googlemail.com> wrote:

> On 29.01.2017 04:46, Ronald S. Bultje wrote:
> > Hm ... So I guess I wasn't clear about this, but the reason I didn't
> reply
> > to other patches with log messages was not because I'm OK with, but
> simply
> > to keep the discussion contained in a single thread and not spam the
> list.
> > I'd prefer if the log msg disappeared from all fuzz-only checks...
>
> Being a "fuzz-only check" is not a well-defined concept. Anything a fuzzer
> does could in principle also happen due to file corruption.


Please stop already. This is ridiculous.

Error messages are supposed to help solve a problem. A corrupt file isn't
solvable. No error message can help. So why bother informing the user?
"Channel count too large" is the same as "fluffybuzz whackabit
mackahooloo". There is no action associated with the message that can help
solve it. This is different from "encryption key missing, please use the
option -key value to specify" for encrypted content.

All we're doing is growing source and binary size and code complexity, and
we do so without any apparent benefit. I just don't think that's a great
approach.

Ronald