[FFmpeg-devel] [PATCH] avcodec/alsdec: properly allocate raw_buffer

Thilo Borgmann thilo.borgmann at mail.de
Sat Jul 1 19:47:55 EEST 2017

Am 01.07.17 um 14:23 schrieb Michael Niedermayer:
> On Sat, Jul 01, 2017 at 03:38:21AM +0200, Paul B Mahol wrote:
>> This also reverts 18f94df8.
>> Fixes #5297.
>> Signed-off-by: Paul B Mahol <onemda at gmail.com>
>> ---
>>  libavcodec/alsdec.c | 7 +------
>>  1 file changed, 1 insertion(+), 6 deletions(-)
> This avoids the crash with the sample, i will leave review to thilo
> as he knows ALS much better than i do

Will test tomorrow, also the other ALS patch.

However, I suspect it works for the fuzzed sample only becuase so many values
are not actually used thus assuming/defining them equal to 0 works. Will see if
I can create a valid sample that actually uses these since specs allow for it.

Might take a while to figure out and if this backfires some day because we don't
handle these extra samples properly the bug will not be found this easily...


More information about the ffmpeg-devel mailing list