[FFmpeg-devel] [PATCH] libavformat/fifo: Fix initialization of underlying AVFormatContext

[Jan Sebechlebsky]

On 07/06/2017 04:28 PM, wm4 wrote:

> On Thu, 6 Jul 2017 16:16:12 +0200
> Jan Sebechlebsky <sebechlebskyjan at gmail.com> wrote:
>
>> On 07/06/2017 01:15 PM, wm4 wrote:
>>
>>> On Thu,  6 Jul 2017 13:05:14 +0200
>>> sebechlebskyjan at gmail.com wrote:
>>>
>>> For what reason?
>> For example RTSP muxer attempts to access filename (url) from
>> AVFormatContext to extract connection parameters and open connection.
>> When the filename is not set, it initializes the connection with default
>> parameters, which is the cause of bug #6308 from trac:
>>
>> https://trac.ffmpeg.org/ticket/6308
>>
>> This commit fixes #6308 and possibly other problems with muxers
>> accessing filename from AVFormatContext.
> Then that should go into the commit message. Nobody likes to lookup
> trac and try to make sense of the user confusion there. Also, trac
> could get replaced or somehow reset in the future, like it happened in
> the past.
Ok, I'll modify the commit message before pushing to:

libavformat/fifo: Fix initialization of underlying AVFormatContext

Muxers may want to directly access filename in stored in AVFormatContext.
For example in case of RTSP, the filename (url) is used by the muxer to
extract parameters of the connection. These muxers will fail when used
with fifo pseudo-muxer.

This commit fixes this issue by passing filename from AVFormatContext
of fifo pseudo-muxer to all AVFormatContext(s) of underlying muxers during
initialization.