[FFmpeg-devel] [PATCH 1/3] avcodec/aacdec_template: Fix undefined integer overflow in apply_tns()
Ronald S. Bultje
rsbultje at gmail.com
Fri Jul 14 16:17:52 EEST 2017
On Fri, Jul 14, 2017 at 6:55 AM, Kieran Kunhya <kierank at obe.tv> wrote:
> On Thu, 13 Jul 2017 at 23:06 Michael Niedermayer <michael at niedermayer.cc>
> > On Wed, Jul 12, 2017 at 01:54:28PM +0000, Kieran Kunhya wrote:
> > > >
> > > > I actually would request a short note explaining the SUINTFLOAT type
> > usage.
> > > > Something like:
> > > > +typedef unsigned SUINTFLOAT; // Equivalent to INTFLOAT,
> > > > Used as temporal cast to avoid undefined sign overflow operations.
> > > >
> > > > Maybe add such note to all "signed value in unsigned type" typedefs.
> > > >
> > >
> > > Needs to be in main documentation because nobody is going to understand
> > > this in 50 years time when mailing lists have bitrotted.
> > ill post a patch that adds this as a doxygen comment in the patch,
> > that way it should be in the doxygen documentation
> > if you meant it to be put some other place clarify where
> I mean full documentation of the thought process behind all these changes
> in doc/.
> Just like James spent weeks trying to fix the undocumented IDCTs from 15
> years ago, someone will probably end up struggling to understand this SUINT
> stuff in 20 years time.
The IDCTs are still not documented by the way... :-). Part of that is hard
because some changes are to reduce round-trip error which requires
More information about the ffmpeg-devel