[FFmpeg-devel] [PATCH 1/7] Revert "Revert "lavfi/buffersrc: push the frame deeper if requested.""

Tobias Rapp t.rapp at noa-archive.com
Mon Jul 17 17:54:50 EEST 2017


On 17.07.2017 16:19, Nicolas George wrote:
> This reverts commit 04aa09c4bcf2d5a634a35da3a3ae3fc1abe30ef8.
>
> The fate-ffm change is caused by field_order now being set
> on the output format because the first frame arrives earlier.
> The fate-mxf change is assumed to be the same.
>
> Signed-off-by: Nicolas George <george at nsup.org>
> ---
>  libavfilter/buffersrc.c | 25 +++++++++++++++++++++++++
>  tests/ref/lavf/ffm      |  2 +-
>  tests/ref/lavf/mxf      |  6 +++---
>  3 files changed, 29 insertions(+), 4 deletions(-)
>
>
> The field_order info seems to not be printed by any tool, and I do not know
> the MXF format to check directly in the file; with FFM it was easy to see in
> a hexdump. Anyway, the fact that field order was not set before de-reverting
> hints at something fishy happening in the initialization code of ffmpeg. I
> do not have time nor motivation to investigate that, so I will assume the
> change is for the best like FFM.

ffprobe should be able to print the stream's field_order since commit 
54350f06e11727f255e3d1829cb1afde49931d8b

>
> If someone wants to investigate, the change can be toggled by simply adding
> "return 0" at the beginning of push_frame(), below.
>
> [...]

Regards,
Tobias




More information about the ffmpeg-devel mailing list