[FFmpeg-devel] [PATCH] Add FITS Demuxer

Paul B Mahol onemda at gmail.com
Tue Jul 18 21:24:15 EEST 2017


On 7/18/17, Nicolas George <george at nsup.org> wrote:
> Le decadi 30 messidor, an CCXXV, Paul B Mahol a ecrit :
>> You are unable to work with as a team.
>
> You may notice that my message did not contain anything ad-hominem.
> This, on the other hand, is pure ad-hoinem.
>
>> I see nothing wrong with either demuxer or decoder code and no
>> duplicated lines of code.
>
> The codde is not duplicated, but the logic is, one reading from a
> buffer, one reading from avio. Proof that this is duplicated : if a typo
> is found in the name of one of the fields, it needs fixing in both lavc
> and lavf. This is not good design. And as such, it cannot be accepted in
> FFmpeg.

Design is just fine. You need to be more constructive, otherwise I will
just assume you want to be evil and ignore your comments.


More information about the ffmpeg-devel mailing list