[FFmpeg-devel] [PATCH] fate: fix source test for sofa2wavs

James Almer jamrial at gmail.com
Mon Jun 12 21:14:12 EEST 2017


On 6/12/2017 3:07 PM, Paul B Mahol wrote:
> On 6/12/17, Michael Bradshaw <mjbshaw-at-google.com at ffmpeg.org> wrote:
>> commit 1a30bf60be9243830b68e8fe2e20539f08a85926 added the sofa2wavs
>> tool, which breaks fate:
>> $ make fate V=1
>> TEST    source
>> ./tests/fate-run.sh fate-source "samples" "" "/Users/mjbshaw/ffmpeg"
>> 'runlocal fate/source-check.sh' '' '' '' '1' '' '' '' '' '' '' '' ''
>> ''
>> ./tests/fate/source-check.sh ./tests
>> --- ./tests/ref/fate/source 2017-06-12 10:34:46.000000000 -0700
>> +++ tests/data/fate/source 2017-06-12 10:48:27.000000000 -0700
>> @@ -12,6 +12,7 @@
>>  libavformat/log2_tab.c
>>  libswresample/log2_tab.c
>>  libswscale/log2_tab.c
>> +tools/sofa2wavs.c
>>  tools/uncoded_frame.c
>>  tools/yuvcmp.c
>>  Headers without standard inclusion guards:
>> Test source failed. Look at tests/data/fate/source.err for details.
>> make: *** [fate-source] Error 1
>>
>> Attached patch updates fate to include the sofa2wavs tool. Please review.
> 
> OK, please apply.

Wouldn't it be better/proper to add the license header to the file instead?


More information about the ffmpeg-devel mailing list