[FFmpeg-devel] fate: Do not report side data size

Nicolas George george at nsup.org
Thu Mar 9 12:12:00 EET 2017


Le nonidi 19 ventôse, an CCXXV, Michael Niedermayer a écrit :
> it is a property of the file in multiple cases
> 
> through the split side data code but even if this is removed
> for example
> AV_PKT_DATA_NEW_EXTRADATA is just binary data from the file the
> length is from the file
> 
> or AV_PKT_DATA_STRINGS_METADATA, which are multiple zero terminated
> strings
> 
> and there is AV_PKT_DATA_MATROSKA_BLOCKADDITIONAL which again is
> basically binary data and length from the file
> 
> If you remove displaying the size based on the argumnet that it
> ideally should be the sizeof of a struct and thus should not be
> printed.
> Then that change should be limited to the cases where this
> argumnet applies

No, this is taking it the wrong way. Side data size being relevant is
the exception, not the rule. Even for AV_PKT_DATA_STRINGS_METADATA, it
is not the relevant information.

Treating it as the rule and not the exception is exactly what lead us to
this problem, and will cause still more maintainability problems in the
future.

The only sane way to go is to remove it now altogether, and only then
add back printing relevant information for specific kinds of side data.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170309/78088f26/attachment.sig>


More information about the ffmpeg-devel mailing list