[FFmpeg-devel] [PATCH] libavcodec/libopenjpegenc.c

Aaron Boxer boxerab at gmail.com
Fri Mar 10 06:09:33 EET 2017


On Thu, Mar 9, 2017 at 10:31 PM, Michael Bradshaw <mjbshaw at gmail.com> wrote:

> On Wed, Mar 8, 2017 at 5:19 AM, Aaron Boxer <boxerab at gmail.com> wrote:
>
> > Final version of simple patch to :
> >
> > limit encoder to single layer
> > add lossless option
> > set better defaults for a few encoding parameters.
>
>
> I think I'd prefer to remove the numlayers option altogether if the only
> possible value it can have is 1.
>
> Small nitpick: please amend the commit message so the first line of the
> message is a short summary of the overall commit, and move the numbered
> list to below the first line. That is, the command git log --pretty=short
> should look something like:
>
> commit 440b7cb6abb32e35464c7c86634d655ccb1d7e7c
> Author: Aaron Boxer <boxerab at gmail.com>
>
>     <some concise summary here on a single line>
>
> The command git log can give the full commit message:
>
> commit 440b7cb6abb32e35464c7c86634d655ccb1d7e7c
> Author: Aaron Boxer <boxerab at gmail.com>
>
>     <some concise summary here on a single line>
>
>     1. limit...
>     2. encoder...
>     3. remove...
>     4. add...
>     5. set...
>


Thanks, Michael. Here are those changes.

Cheers,
Aaron
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-libavcodec-libopenjpegenc-enable-lossless-option-rem.patch
Type: application/octet-stream
Size: 3975 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170309/672eb30a/attachment.obj>


More information about the ffmpeg-devel mailing list