[FFmpeg-devel] [PATCH]lavc/avpacket: Make pkt parameter of av_packet_get_side_data() const

Michael Niedermayer michael at niedermayer.cc
Sat Mar 11 16:24:22 EET 2017


On Tue, Mar 07, 2017 at 09:59:42AM +0100, Carl Eugen Hoyos wrote:
> 2017-02-26 12:04 GMT+01:00 Carl Eugen Hoyos <ceffmpeg at gmail.com>:
> > 2017-02-26 11:51 GMT+01:00 Nicolas George <george at nsup.org>:
> 
> >>> -uint8_t* av_packet_get_side_data(AVPacket *pkt, enum AVPacketSideDataType type,
> >>
> >>> +uint8_t* av_packet_get_side_data(
> >>> +#if FF_API_CONST_GET_SIDE_DATA
> >>> +const
> >>> +#endif
> >>> +                                 AVPacket *pkt, enum AVPacketSideDataType type,
> >>
> >> I do not think we need the FF_API dance, since it is not an ABI break.
> >
> > I agree that there is no ABI break (but I suspect FF_API does not
> > imply an ABI break).
> >
> >> I think is is not an API break either.
> >
> > I may misremember but I thought it's an API break for c++ users.
> >
> > Anyway, new patch attached.
> 
> Ping.
> Should this not be changed, should one of the patches be applied?

i agree one should be applied, iam not 100% sure if it can break a
user app and need the #if or not

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

No human being will ever know the Truth, for even if they happen to say it
by chance, they would not even known they had done so. -- Xenophanes
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170311/0d1f0d6d/attachment.sig>


More information about the ffmpeg-devel mailing list