[FFmpeg-devel] [PATCH] Change type of spherical stuff to uint32_t

Ronald S. Bultje rsbultje at gmail.com
Mon Mar 13 02:54:07 EET 2017


Hi,

On Sun, Mar 12, 2017 at 7:32 PM, James Almer <jamrial at gmail.com> wrote:

> On 3/12/2017 6:16 PM, Michael Niedermayer wrote:
> > Using the same type across platforms is more robust and avoids platform
> > specific issues from differences in range.
> > Also fixed point integers are on a semantical level not size_t
> >
> > Previous version reviewed-by: James Almer <jamrial at gmail.com>
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  ffprobe.c             |  2 +-
> >  libavformat/dump.c    |  6 +++---
> >  libavutil/spherical.c |  6 +++---
> >  libavutil/spherical.h | 16 ++++++++--------
> >  4 files changed, 15 insertions(+), 15 deletions(-)
>
> Needs FATE update.


Since this is Vittorio's code, it's probably good to ask him [CC]? From
memory, he seemed to prefer size_t.

Ronald


More information about the ffmpeg-devel mailing list