[FFmpeg-devel] [PATCH v2] avformat/rtmpproto: change rtmp_open from url_open to url_open2

Michael Niedermayer michael at niedermayer.cc
Fri Mar 17 03:00:10 EET 2017


On Thu, Mar 16, 2017 at 08:31:34PM +0800, Steven Liu wrote:
> use the option set by user
> 
> Reported-by: Lancelot Lai <laihy23 at gmail.com>
> Signed-off-by: Steven Liu <lq at chinaffmpeg.org>
> ---
>  libavformat/rtmpproto.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)

This causes rtmp to segfault:
example:
./ffmpeg_g  -rtmp_live 0 -i rtmp://127.0.0.1 file.avi

[tcp @ 0x20f0b80] Connection to tcp://127.0.0.1:1935 failed: Connection refused
[rtmp @ 0x20f0420] Cannot open connection tcp://127.0.0.1:1935

Program received signal SIGSEGV, Segmentation fault.
0x00000000010ffd03 in av_dict_get ()
(gdb) bt
#0  0x00000000010ffd03 in av_dict_get ()
#1  0x00000000010fff6a in av_dict_set ()
#2  0x0000000000630976 in ffurl_connect ()
#3  0x0000000000631286 in ffurl_open_whitelist ()
#4  0x00000000006354c5 in ffio_open_whitelist ()
#5  0x00000000006eb2b1 in io_open_default ()
#6  0x00000000007460ed in avformat_open_input ()
#7  0x00000000004b051b in open_input_file ()
#8  0x00000000004ade9c in open_files.isra ()
#9  0x00000000004b564c in ffmpeg_parse_options ()
#10 0x00000000004a5a1e in main ()


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170317/34ca0e34/attachment.sig>


More information about the ffmpeg-devel mailing list