[FFmpeg-devel] [PATCH 1/2] avcodec/h264_ps: Fix runtime error: signed integer overflow: 2147483647 + 26 cannot be represented in type 'int'

Ronald S. Bultje rsbultje at gmail.com
Wed Mar 22 14:45:59 EET 2017


Hi,

On Tue, Mar 21, 2017 at 9:59 PM, Michael Niedermayer <michael at niedermayer.cc
> wrote:

> Fixes: 902/clusterfuzz-testcase-4561155144024064
>
> Found-by: continuous fuzzing process https://github.com/google/oss-
> fuzz/tree/master/targets/ffmpeg
> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> ---
>  libavcodec/h264_ps.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavcodec/h264_ps.c b/libavcodec/h264_ps.c
> index 65d164d81c..b78ad251f5 100644
> --- a/libavcodec/h264_ps.c
> +++ b/libavcodec/h264_ps.c
> @@ -800,8 +800,8 @@ int ff_h264_decode_picture_parameter_set(GetBitContext
> *gb, AVCodecContext *avct
>
>      pps->weighted_pred                        = get_bits1(gb);
>      pps->weighted_bipred_idc                  = get_bits(gb, 2);
> -    pps->init_qp                              = get_se_golomb(gb) + 26 +
> qp_bd_offset;
> -    pps->init_qs                              = get_se_golomb(gb) + 26 +
> qp_bd_offset;
> +    pps->init_qp                              = get_se_golomb(gb) + 26U +
> qp_bd_offset;
> +    pps->init_qs                              = get_se_golomb(gb) + 26U +
> qp_bd_offset;
>      pps->chroma_qp_index_offset[0]            = get_se_golomb(gb);
>      if (pps->chroma_qp_index_offset[0] < -12 ||
> pps->chroma_qp_index_offset[0] > 12) {
>          ret = AVERROR_INVALIDDATA;
> --
> 2.11.0


OK.

Ronald


More information about the ffmpeg-devel mailing list