[FFmpeg-devel] [PATCH 2/2] avcodec/h264: Check weight values to be within the specs limits.

Alexander Strasser eclipse7 at gmx.net
Fri Mar 24 00:29:47 EET 2017


On 2017-03-22 09:06 -0400, Ronald S. Bultje wrote:
> On Tue, Mar 21, 2017 at 9:59 PM, Michael Niedermayer <michael at niedermayer.cc
> > wrote:
> 
> > @@ -59,6 +59,9 @@ int ff_h264_pred_weight_table(GetBitContext *gb, const
> > SPS *sps,
> >              if (luma_weight_flag) {
> >                  pwt->luma_weight[i][list][0] = get_se_golomb(gb);
> >                  pwt->luma_weight[i][list][1] = get_se_golomb(gb);
> > +                if (   (int8_t)pwt->luma_weight[i][list][0] !=
> > pwt->luma_weight[i][list][0]
> > +                    || (int8_t)pwt->luma_weight[i][list][1] !=
> > pwt->luma_weight[i][list][1])
> > +                    goto error;
> >
> 
> Can we please put || on the line before? h264* and a very limited subset of
> other files in our codebase have always been an exception to the large
> majority of the codebase and it's about time we fix that [1].

  No strong opinion on this one, but putting operators in front on the next
line makes them stay aligned in case a name changes later on. I think it is
a little bit easier to read too.

  I did not check the counts, but I guess putting the logical operators at
the end is used far more common in our code base and in no way do I suggest 
we should change all of those occurrences to this style.


[...]

  Alexander


More information about the ffmpeg-devel mailing list