[FFmpeg-devel] [PATCH]lavc/h264_ps: Check chroma_location limits

Ronald S. Bultje rsbultje at gmail.com
Fri Mar 24 13:48:53 EET 2017


Hi,

On Fri, Mar 24, 2017 at 7:40 AM, Ronald S. Bultje <rsbultje at gmail.com>
wrote:

> Hi,
>
> On Fri, Mar 24, 2017 at 6:23 AM, Carl Eugen Hoyos <ceffmpeg at gmail.com>
> wrote:
>
>> there are several similar cases there.
>
>
> That is classically how ff_ symbols became public API. Please don't use
> that argument ever again.
>

Btw, I'm not arguing with your suggestion that maybe _NB should be
redefined to be part of our API but the value in runtime libavutil may be
bigger. It may or may not be a good idea, I don't know.

I'm merely arguing with the point that since we violate the API already,
it's OK to violate it some more.

Ronald


More information about the ffmpeg-devel mailing list