[FFmpeg-devel] [FFmpeg-cvslog] Implement optimal huffman encoding for (M)JPEG.

[James Almer]

On 3/16/2017 6:24 PM, James Almer wrote:
>> ffmpeg | branch: master | Jerry Jiang <jerryjiang1128 at gmail.com> | Wed Feb  1 23:23:04 2017 -0800| [884506dfe2e29a5b2bd2905ca4f17e277e32acb1] | committer: Rostislav Pehlivanov
>>
>> Implement optimal huffman encoding for (M)JPEG.
>>
>>> seems to break
>>> make fate-vsynth1-mjpeg-444
>>
>> Fixed.
>>
>>> http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=884506dfe2e29a5b2bd2905ca4f17e277e32acb1
>> ---
>>
>>  Changelog                                        |   1 +
>>  doc/encoders.texi                                |  21 ++
>>  libavcodec/Makefile                              |   8 +-
>>  libavcodec/mjpegenc.c                            | 243 +++++++++++++++++------
>>  libavcodec/mjpegenc.h                            |  68 ++++++-
>>  libavcodec/mjpegenc_common.c                     | 166 +++++++++++++++-
>>  libavcodec/mjpegenc_common.h                     |   2 +
>>  libavcodec/mjpegenc_huffman.c                    | 195 ++++++++++++++++++
>>  libavcodec/mjpegenc_huffman.h                    |  74 +++++++
>>  libavcodec/mpegvideo.h                           |   1 +
>>  libavcodec/mpegvideo_enc.c                       |  17 +-
>>  libavcodec/tests/.gitignore                      |   1 +
>>  libavcodec/tests/mjpegenc_huffman.c              | 163 +++++++++++++++
>>  tests/fate/libavcodec.mak                        |   6 +
>>  tests/fate/vcodec.mak                            |  12 +-
>>  tests/ref/vsynth/vsynth1-mjpeg-huffman           |   4 +
>>  tests/ref/vsynth/vsynth1-mjpeg-trell-huffman     |   4 +
>>  tests/ref/vsynth/vsynth2-mjpeg-huffman           |   4 +
>>  tests/ref/vsynth/vsynth2-mjpeg-trell-huffman     |   4 +
>>  tests/ref/vsynth/vsynth3-mjpeg-huffman           |   4 +
>>  tests/ref/vsynth/vsynth3-mjpeg-trell-huffman     |   4 +
>>  tests/ref/vsynth/vsynth_lena-mjpeg-huffman       |   4 +
>>  tests/ref/vsynth/vsynth_lena-mjpeg-trell-huffman |   4 +
>>  23 files changed, 914 insertions(+), 96 deletions(-)
>>
> 
> This broke valgrind/gcc-asan
> 
> http://fate.ffmpeg.org/report.cgi?time=20170316170150&slot=x86_64-archlinux-gcc-asan

Ping. These are invalid reads, so ideally should be fixed before the new release.

Most recent Asan and Valgrind reports:
http://fate.ffmpeg.org/report.cgi?time=20170325063317&slot=x86_64-archlinux-gcc-asan
http://fate.ffmpeg.org/report.cgi?time=20170325111002&slot=x86_64-archlinux-gcc-valgrind