[FFmpeg-devel] [PATCH] doc/examples/encode_audio: Favor a sample rate close to 44khz instead of the maximum sample rate

Michael Niedermayer michael at niedermayer.cc
Thu Mar 30 17:17:58 EEST 2017


On Thu, Mar 30, 2017 at 09:37:34PM +0800, Steven Liu wrote:
> 2017-03-30 21:12 GMT+08:00 Michael Niedermayer <michael at niedermayer.cc>:
> 
> > This is an example, people will copy and use this. The maximum supported
> > is quite
> > unreasonable as a default choice
> >
> > Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> > ---
> >  doc/examples/encode_audio.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/doc/examples/encode_audio.c b/doc/examples/encode_audio.c
> > index 88d0a6fd46..ba9ef6ddb8 100644
> > --- a/doc/examples/encode_audio.c
> > +++ b/doc/examples/encode_audio.c
> > @@ -62,7 +62,8 @@ static int select_sample_rate(const AVCodec *codec)
> >
> >      p = codec->supported_samplerates;
> >      while (*p) {
> > -        best_samplerate = FFMAX(*p, best_samplerate);
> > +        if (!best_samplerate || abs(44100 - *p) < abs(44100 -
> > best_samplerate))
> > +            best_samplerate = *p;
> >          p++;
> >      }
> >      return best_samplerate;
> > --
> > 2.11.0
> >
> > _______________________________________________
> > ffmpeg-devel mailing list
> > ffmpeg-devel at ffmpeg.org
> > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> 
> 
> 
> LGTM

applied

thx

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

He who knows, does not speak. He who speaks, does not know. -- Lao Tsu
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170330/2b57bc4a/attachment.sig>


More information about the ffmpeg-devel mailing list