[FFmpeg-devel] [PATCH] avfilter: align data frame when needed

[Muhammad Faiz]

On Fri, May 5, 2017 at 11:22 PM, Nicolas George <george at nsup.org> wrote:
> Le sextidi 16 floréal, an CCXXV, Muhammad Faiz a écrit :
>>                                                   But if documentation
>> says that data should be aligned to 4-bytes but I align it to
>> 32-bytes, then there are no violations at all. So what's wrong with
>> this patch?
>
> Useless code performing wasteful operations in speed-critical sections.

This is not speed-critical section.
The command:
./ffmpeg -filter_complex "aevalsrc=0:d=1000, aformat=fltp,
firequalizer=fixed=on:delay=0.0013, volume=0.5" -f null null
segfault at eof. So, this section is rarely executed.
And code below this section do extensive copying.


>
> Write the doc, and we can discuss.