[FFmpeg-devel] [PATCH 1/3] lavu/frame: add av_frame_check_align().

Hendrik Leppkes h.leppkes at gmail.com
Thu May 11 00:11:58 EEST 2017


On Wed, May 10, 2017 at 11:10 PM, Nicolas George <george at nsup.org> wrote:
> Le primidi 21 floréal, an CCXXV, Hendrik Leppkes a écrit :
>> Everywhere I found where the align value is used, its used as (1 <<
>> alignment). In that case, I would prefer to pass the actual alignment
>> here (ie. 32 instead of 5), which is an easier value to understand and
>> matches the various alignment constants/values we already had before.
>
> I can live with that, but here is my rationale for doing it that way:
> log2(align_mult) is a non-trivial function while 1<<align_log is a CPU
> built-in.
>
>

Perhaps, but its not used like that anywhere, and I can't imagine
why/where we would. Anything you had in mind when that might be
needed?

- Hendrik


More information about the ffmpeg-devel mailing list