[FFmpeg-devel] [PATCH] lavf/mov: make invalid mdhd time_scale default to 1 instead of erroring out

Matthieu Bouron matthieu.bouron at gmail.com
Wed May 17 14:56:13 EEST 2017


On Fri, May 12, 2017 at 11:12:12PM +0200, Michael Niedermayer wrote:
> On Thu, May 11, 2017 at 04:33:50PM +0200, Matthieu Bouron wrote:
> > Some samples have their metadata track time_scale incorrectly set to 0
> > and the check introduced by a398f054fdb9b0f0b5a91c231fba6ce014143f71
> > prevents playback of those samples. Setting the time_scale to 1 fixes
> > playback.
> > ---
> >  libavformat/mov.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> should be ok

Do you agree if I extend the patch to apply this behaviour to the mvhd
atoms (like a398f054fdb9b0f0b5a91c231fba6ce014143f71 originally did) ?

> please add a fate test

I will. Is it mandatory in order to get this patch applied (as I would
like to apply this patch as soon as possible) ?

[...]

-- 
Matthieu B.


More information about the ffmpeg-devel mailing list