[FFmpeg-devel] [PATCH 1/2] lavfi: check links properties after configuring them.

Nicolas George george at nsup.org
Thu Nov 2 00:01:22 EET 2017


Le primidi 11 brumaire, an CCXXVI, Clement Boesch a écrit :
> nb_filters and nb_outputs are signed so the counters better be the same
> type.

I re-checked, I think you are mistaken.

> I think we already had that discussion but I'd rather have the counters
> signed so the compiler can exploit the undefined property of signed
> overflow to assume it will never happen.

On the other hand, it forces it to make code that can handle negative as
well, even though the value are positive. I really think it is better to
inform the compiler of the intent, and the intent is that the numbers
are positive, i.e. unsigned.

Regards,

-- 
  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171101/6597f814/attachment.sig>


More information about the ffmpeg-devel mailing list