[FFmpeg-devel] [PATCH 0/6] avcodec: Vorbis encoder improvements

[Rostislav Pehlivanov]

On 22 August 2017 at 02:23, Tyler Jones <tdjones879 at gmail.com> wrote:

> Please see the following patches.
>
> The first two patches are identical to my latest pending changes sent to
> the
> mailing list on July 28. Changelogs are included regardless. The clipping
> avoidance patch should remove most clicking that had been noticed by
> atomnuker in previous versions.
>
> Thanks in advance.
>
> Tyler Jones (5):
>   avcodec/vorbisenc: Add pre-echo detection
>    V4: Use AVFloatDSPContext for variance calculation
>     Correctly change quality factors to const
>     Remove unnecessary malloc and free for VorbisPsyContext
>
>    V3: Use normal float notation
>     Don't check before freeing NULL pointers
>     Remove unnecessary includes
>
>    V2: Provide proper prefix for non-static function
>
>   avcodec/vorbisenc: Apply dynamic frame lengths
>    V4: No changes
>    V3: Switch 'bits[p] == 0' to '!bits[p]' in vlc gen
>    V2: Fix double arithmetic in window scale
>   avcodec/vorbisenc: Add clipping avoidance
>   avcodec/vorbisenc: Move encoder structures and macros to separate file
>   avcodec/vorbisenc: Separate floor and residue configurations
>   avcodec/vorbisenc: Add support for mono streams
>
>  libavcodec/Makefile          |   2 +-
>  libavcodec/vorbis.c          |  10 +-
>  libavcodec/vorbis_enc_data.h | 576 ++++++++++++++++++++++++++++++-------
>  libavcodec/vorbisenc.c       | 666 ++++++++++++++++++++++--------
> -------------
>  libavcodec/vorbisenc.h       | 145 ++++++++++
>  libavcodec/vorbispsy.c       | 164 +++++++++++
>  libavcodec/vorbispsy.h       |  92 ++++++
>  tests/fate/vorbis.mak        |   2 +-
>  8 files changed, 1220 insertions(+), 437 deletions(-)
>  create mode 100644 libavcodec/vorbisenc.h
>  create mode 100644 libavcodec/vorbispsy.c
>  create mode 100644 libavcodec/vorbispsy.h
>
> --
> 2.14.1
>
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
>


Hi,

Sorry it took so long but I finally took a look at the patches.

You'll need to recreate patch #2 and onwards since they don't apply:


> error: sha1 information is lacking or useless (libavcodec/vorbisenc.c).
> error: could not build fake ancestor
>