[FFmpeg-devel] [PATCH] avformat/hlsenc: creation of hls variant streams with master playlist in a single hlsenc instance

[Dixit, Vishwanath]

>On 11/16/17, 12:09 PM, "刘歧" <lq at chinaffmpeg.org> wrote:
>
>    FATE test passed:  Ubuntu, OS X, qemu+MIPS Linux,  wine MingW, qemu+ARM Linux, Thanks.
>   
> +    if (p) {
>    +        strcpy(extension, p);
>    What about use av_strlcpy ?
>    
 > +        while (q < varstr + strlen(varstr)) {
 >   +            if (!strncmp(q, "a:", 2) || !strncmp(q, "v:", 2) ||
 >   +                !strncmp(q, "s:", 2))
 >   What about use av_strcasecmp ?
>   
> +            } else {
>    +                av_log(s, AV_LOG_ERROR, "Invalid keyval %s\n", keyval);
>    +                return -1;
>    What about use return AVERROR(EINVAL)?
 >  
 > +            } else {
 >   +                av_log(s, AV_LOG_ERROR, "Unable to map stream at %s\n", keyval);
 >   +                return -1;
 >   same as above.
> 
>+            strrchr(master_url, '\\');
>    +    if (p) {
>    +        base_len = abs(p - master_url);
>    use FFABS
>      
 >   +        if (strncmp(master_url, media_url, base_len)) {
 >   use av_strcasecmp
    
I have made updates for all the review comments. Please find the updated patch set in the attachment.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-avformat-hlsenc-creation-of-hls-variant-streams-in-a.patch
Type: application/octet-stream
Size: 71698 bytes
Desc: 0001-avformat-hlsenc-creation-of-hls-variant-streams-in-a.patch
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171116/95fb708c/attachment.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-avformat-hlsenc-creation-of-hls-master-playlist-file.patch
Type: application/octet-stream
Size: 12315 bytes
Desc: 0002-avformat-hlsenc-creation-of-hls-master-playlist-file.patch
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171116/95fb708c/attachment-0001.obj>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-tests-fate-addition-of-test-case-for-hls-variant-str.patch
Type: application/octet-stream
Size: 93493 bytes
Desc: 0003-tests-fate-addition-of-test-case-for-hls-variant-str.patch
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171116/95fb708c/attachment-0002.obj>