[FFmpeg-devel] [PATCH 1/3] libavformat/avio: Utility function to return URLContext

Nicolas George george at nsup.org
Thu Nov 16 13:13:25 EET 2017

Le sextidi 26 brumaire, an CCXXVI, Jeyapal, Karthick a écrit :
> Thanks for the feedback. I have a relevant condition check so that
> only a real URLContext is returned.
> Please find the new patch attached.

I think that would work, thanks.

But I see that in the other patches you call ffio_geturlcontext()
without checking its return value. That is not good at all, and that
would make Coverity squirm.

If you are sure that you are always calling it with a real URLContext,
then make the test an av_assert0(). I think it is the case. Otherwise,
you need to check the return value.

Also, I see the other patch calling prot->url_write directly: I think it
should call ffurl_write() instead.


  Nicolas George
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171116/7a42ee12/attachment.sig>

More information about the ffmpeg-devel mailing list