[FFmpeg-devel] [PATCH] build: don't strip binaries during compilation

[James Almer]

On 10/1/2017 8:22 PM, Carl Eugen Hoyos wrote:
> 2017-10-02 1:20 GMT+02:00 James Almer <jamrial at gmail.com>:
>> On 10/1/2017 8:18 PM, Carl Eugen Hoyos wrote:
>>> 2017-10-02 0:55 GMT+02:00 James Almer <jamrial at gmail.com>:
>>>> Do it during install instead, like with the libraries.
>>>>
>>>> There's no benefit making a stripped copy of the CLI tools in the
>>>> build folder. Doing it during install saves build time and storage
>>>> space.
>>>
>>> This makes it much more difficult to request backtrace etc.
>>> from users.
>>
>> How so? The installed binaries are always stripped (unless configured
>> with --disable-stripping), with or without this patch.
> 
> We currently simply ask for "ffmpeg_g" output, even a user
> who has no idea about debugging either has this executable
> or not.
> 
> Carl Eugen

Then we start asking for ffmpeg output. We always request testing and
backtraces using git head, and after this patch that will always be an
unstripped binary, so I don't get how this is an issue.