[FFmpeg-devel] [PATCH]lavc/utvideo: Use "&" instead of "&&" in expressions with "~"

Carl Eugen Hoyos ceffmpeg at gmail.com
Mon Oct 9 00:09:42 EEST 2017


2017-10-08 1:58 GMT+02:00 Ronald S. Bultje <rsbultje at gmail.com>:
> Hi,
>
> On Sat, Oct 7, 2017 at 7:05 PM, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>
>> Hi!
>>
>> Attached patch silences two warnings when compiling with gcc-7:
>> libavcodec/utvideodec.c:242:107: warning: ‘~’ on a boolean expression
>> [-Wbool-operation]
>>      const int cmask = c->interlaced ? ~(1 + 2 * (!plane_no &&
>> c->avctx->pix_fmt == AV_PIX_FMT_YUV420P)) : ~(!plane_no &&
>> c->avctx->pix_fmt == AV_PIX_FMT_YUV420P);

> I personally think the warning is dumb...

I am less convinced but disabled the warning.

Thank you both, Carl Eugen


More information about the ffmpeg-devel mailing list