[FFmpeg-devel] [PATCH] Fix visual glitch with XvMC, caused by wrong idct permutation.

Michael Niedermayer michael at niedermayer.cc
Mon Oct 9 21:12:56 EEST 2017


On Mon, Oct 09, 2017 at 09:02:38AM -0400, Ronald S. Bultje wrote:
> Hi,
> 
> On Mon, Oct 9, 2017 at 6:46 AM, Ivan Kalvachev <ikalvachev at gmail.com> wrote:
> 
> > On 10/9/17, Ronald S. Bultje <rsbultje at gmail.com> wrote:
> > > On Sun, Oct 8, 2017 at 6:52 PM, Ivan Kalvachev <ikalvachev at gmail.com>
> > wrote:
> > > [..]
> > >
> > > Indentation is off in the second hunk, can you fix that?
> >
> > You want it 4 spaces to the right
> >
> 
> Yes, please.
> 
> BTW, I think it would be better to use "127" number.
> >
> 
> I don't really mind either way. The number 128 suggests it may have been
> intended as a bitmask. Michael is probably better positioned to comment on
> this.

I dont really remember but i think 128 was choosen for ABI
compatibility with additions to it from libav. So it shuld no longer
matter what values are used on additions

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

What does censorship reveal? It reveals fear. -- Julian Assange
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171009/90f67075/attachment.sig>


More information about the ffmpeg-devel mailing list