[FFmpeg-devel] [PATCH] configure: fix decklink dependencies

[Marton Balint]

On Tue, 10 Oct 2017, James Almer wrote:

> On 10/10/2017 5:44 PM, Marton Balint wrote:
>> 
>> 
>> On Tue, 10 Oct 2017, James Almer wrote:
>> 
>>> On 10/10/2017 3:34 PM, James Almer wrote:
>>>> On 10/10/2017 3:22 PM, Marton Balint wrote:
>>>>> We don't need libdl for win32/mingw.
>>>>
>>>> Sorry about that.
>>>>
>>>>>
>>>>> Signed-off-by: Marton Balint <cus at passwd.hu>
>>>>> ---
>>>>>  configure | 5 +++--
>>>>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/configure b/configure
>>>>> index e9e1a4dff3..e2ef54fb3b 100755
>>>>> --- a/configure
>>>>> +++ b/configure
>>>>> @@ -3084,9 +3084,10 @@ avfoundation_indev_deps="avfoundation pthreads"
>>>>>  avfoundation_indev_extralibs="-framework Foundation -framework
>>>>> CoreVideo -framework CoreMedia"
>>>>>  bktr_indev_deps_any="dev_bktr_ioctl_bt848_h machine_ioctl_bt848_h
>>>>> dev_video_bktr_ioctl_bt848_h dev_ic_bt8xx_h"
>>>>>  caca_outdev_deps="libcaca"
>>>>> -decklink_indev_deps="decklink threads libdl"
>>>>> +decklink_deps_any="libdl LoadLibrary"
>>>>> +decklink_indev_deps="decklink threads"
>>>>>  decklink_indev_extralibs="-lstdc++"
>>>>> -decklink_outdev_deps="decklink threads libdl"
>>>>> +decklink_outdev_deps="decklink threads"
>>>>>  decklink_outdev_extralibs="-lstdc++"
>>>>>  libndi_newtek_indev_deps="libndi_newtek libdl"
>>>>>  libndi_newtek_indev_extralibs="-lndi"
>>>>>
>>>>
>>>> Looks good, but i can't test.
>>>
>>> Would this have to be done for libndi_newtek as well, for that matter?
>>> Is the SDK available for Windows?
>> 
>> Yes, there is a Windows SDK. However, as far as I see the code does not
>> use dynamic loading, so maybe we should simply remove the libdl
>> dependency in this case. I am not sure why it was added in the first
>> place, probably a copy/paste from decklink.
>
> It used to be $ldl added to libndi_newtek_{indev,outdev}_extralibs,
> which after a merge i did was changed into a libdl _dep. So yeah,
> probably copy paste from decklink.
> If it doesn't need either libdl or LoadLibrary then please also remove
> its libdl _dep item as a separate patch.
>

Ok, pushed the patch, will send a new one for libndi_newtek.

Regards,
Marton