[FFmpeg-devel] [PATCH] configure: force erroring out in check_disable_warning() if an option doesn't exists

James Almer jamrial at gmail.com
Fri Oct 13 17:14:18 EEST 2017


On 10/12/2017 6:30 PM, James Almer wrote:
> Should prevent some options from being added to cflags when they
> don't exist and the compiler only warns about it.
> 
> Signed-off-by: James Almer <jamrial at gmail.com>
> ---
> I figure this is safer than adding
> -Werror=unused-command-line-argument -Werror=unknown-warning-option
> as Ronald suggested.
> 
>  configure | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/configure b/configure
> index ade67a31bb..c7962665f1 100755
> --- a/configure
> +++ b/configure
> @@ -6370,7 +6370,7 @@ fi
>  
>  check_disable_warning(){
>      warning_flag=-W${1#-Wno-}
> -    test_cflags $warning_flag && add_cflags $1
> +    test_cflags -Werror $warning_flag && add_cflags $1
>  }
>  
>  check_disable_warning -Wno-parentheses

Ping. This or a similar solution has been annoying Clang users for some
days now and should be part of the 3.4 release.


More information about the ffmpeg-devel mailing list