[FFmpeg-devel] [PATCH] avcodec/version: Postpone FF_API_DEBUG_MV

[Michael Niedermayer]

On Sat, Oct 21, 2017 at 10:30:45PM -0300, James Almer wrote:
> On 10/21/2017 10:23 PM, Michael Niedermayer wrote:
> > On Sat, Oct 21, 2017 at 08:52:26PM -0400, Ronald S. Bultje wrote:
> >> Hi,
> >>
> >> On Sat, Oct 21, 2017 at 8:37 PM, Michael Niedermayer <michael at niedermayer.cc
> >>> wrote:
> >>
> >>> This is different from FF_API_VISMV which is supported through codecview.
> >>>
> >>> Signed-off-by: Michael Niedermayer <michael at niedermayer.cc>
> >>> ---
> >>>  libavcodec/version.h | 2 +-
> >>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>
> >>> diff --git a/libavcodec/version.h b/libavcodec/version.h
> >>> index 8584bb7006..25696690d7 100644
> >>> --- a/libavcodec/version.h
> >>> +++ b/libavcodec/version.h
> >>> @@ -79,7 +79,7 @@
> >>>  #define FF_API_SET_DIMENSIONS    (LIBAVCODEC_VERSION_MAJOR < 58)
> >>>  #endif
> >>>  #ifndef FF_API_DEBUG_MV
> >>> -#define FF_API_DEBUG_MV          (LIBAVCODEC_VERSION_MAJOR < 58)
> >>> +#define FF_API_DEBUG_MV          (LIBAVCODEC_VERSION_MAJOR < 59)
> >>>  #endif
> >>>
> >>
> >> Can you give an explanation for why this should be delayed? (It's missing
> >> in the commit message, and this is hard to evaluate without a
> >> justification/explanation.)
> > 
> > It was not agreed on ffmpeg-devel to remove this feature.
> 
> I'm sorry, but you merged this deprecation in 2013. See ffmpeg commit
> c6c03dfdf1692137111fe4aea0b72a1cff08f71e.

thats one i think was the code which we now have in codecview.
So that itself should be ok to remove


> 
> The commit even states it should have removed "all traces of its use",
> but it looks like with the years more and more code was added to it,
> seeing the removal commit 8933ac2079644fb09916f1875c569103aefe84b1 in
> libav doesn't even feature the massive amount of code we have under this
> deprecation wrapper in mpegvideo.
> So basically, the functionality was deprecated, but then further
> developed to the point removing it is almost impossible.
> 
> How the hell did this happen?

I dont know, maybe,
Libav deprecating and removing as much FFmpeg code as they can
FFmpeg continuing to work on the FFmpeg code

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Does the universe only have a finite lifespan? No, its going to go on
forever, its just that you wont like living in it. -- Hiranya Peiri
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20171022/bc7065b5/attachment.sig>