[FFmpeg-devel] [PATCH] RFC: drop VDA

James Almer jamrial at gmail.com
Thu Sep 7 06:01:56 EEST 2017


On 9/5/2017 10:57 AM, Clément Bœsch wrote:
> From: Clément Bœsch <cboesch at gopro.com>
> 
> I'm reworking the Apple Framework dependencies in the build system, and
> unfortunately I can't test VDA (because OSX doesn't have it anymore).
> I'll either break it badly without being able to fix it, or won't be
> able to do any the rework in the build system.
> ---
>  MAINTAINERS                                     |   1 -
>  Makefile                                        |   3 -
>  configure                                       |  15 +-
>  ffmpeg.h                                        |   2 -
>  ffmpeg_opt.c                                    |   6 +-
>  ffmpeg_videotoolbox.c                           |  45 +--
>  libavcodec/Makefile                             |   7 +-
>  libavcodec/allcodecs.c                          |   3 -
>  libavcodec/h264_slice.c                         |   5 -
>  libavcodec/vda.c                                |  84 -----
>  libavcodec/vda.h                                | 230 -------------
>  libavcodec/vda_h264.c                           | 425 ------------------------
>  libavcodec/vda_h264_dec.c                       | 263 ---------------
>  libavcodec/videotoolbox.c                       |  10 +-
>  libavcodec/{vda_vt_internal.h => vt_internal.h} |  15 +-
>  libavutil/pixdesc.c                             |  10 -
>  libavutil/pixfmt.h                              |   4 +-
>  17 files changed, 15 insertions(+), 1113 deletions(-)
>  delete mode 100644 libavcodec/vda.c
>  delete mode 100644 libavcodec/vda.h
>  delete mode 100644 libavcodec/vda_h264.c
>  delete mode 100644 libavcodec/vda_h264_dec.c
>  rename libavcodec/{vda_vt_internal.h => vt_internal.h} (81%)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 8a6ac9840f..7c34912ee6 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -244,7 +244,6 @@ Codecs:
>    txd.c                                 Ivo van Poorten
>    vc2*                                  Rostislav Pehlivanov
>    vcr1.c                                Michael Niedermayer
> -  vda_h264_dec.c                        Xidorn Quan

https://ffmpeg.org/pipermail/ffmpeg-devel/2015-April/171118.html

You could CC him to see if he still cares about this code, but judging
by that email (second to last he's ever sent), I'd say this patch can go
in as it's pretty much a superfluous feature now that Videotoolbox exists.

>    videotoolboxenc.c                     Rick Kern
>    vima.c                                Paul B Mahol
>    vorbisdec.c                           Denes Balatoni, David Conrad



More information about the ffmpeg-devel mailing list