[FFmpeg-devel] [PATCH 3/4] avdevice/decklink_dec: Added Closed caption decode from VANC

Jeyapal, Karthick kjeyapal at akamai.com
Thu Sep 14 08:45:16 EEST 2017


Hi Marton,

Thanks a lot for your comments. I have modified the patch as per all your comments, except the below one.

>> +            tgt = teletext_data_unit_from_ancillary_packet(buf, buf + 1920, tgt, cctx->teletext_lines, 0);
>
>this should be
>                tgt = teletext_data_unit_from_ancillary_packet(buf, buf + len, tgt, cctx->teletext_lines, 1);
>

I have modified it as

tgt = teletext_data_unit_from_ancillary_packet(buf, buf + len, tgt, cctx->teletext_lines, 0);

That was just to be in consistency with the existing code. Because current code passes allow_multipacket as 0. Let me know if my understanding here is correct.

Please find the patch attached.

Regards,
Karthick



-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-avdevice-decklink_dec-Added-Closed-caption-decode-fr.patch
Type: application/octet-stream
Size: 9930 bytes
Desc: 0003-avdevice-decklink_dec-Added-Closed-caption-decode-fr.patch
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170914/e7a51e04/attachment.obj>


More information about the ffmpeg-devel mailing list