[FFmpeg-devel] [PATCH 1/2] avcodec/wmv2dec: Check end of bitstream in parse_mb_skip() and ff_wmv2_decode_mb()

Ronald S. Bultje rsbultje at gmail.com
Sun Sep 17 23:16:13 EEST 2017


Hi,

On Sat, Sep 16, 2017 at 8:42 PM, Michael Niedermayer <michael at niedermayer.cc
> wrote:

> +    if (get_bits_left(&s->gb) < 0) {
> +        av_log(s->avctx, AV_LOG_ERROR,
> +                "Insufficient bits left at %d %d\n", s->mb_x, s->mb_y);
> +        return AVERROR_INVALIDDATA;
> +    }


We've talked about this before, av_log(AV_LOG_ERROR) is not appropriate for
such terse and unhelpful messages that really only apply to fuzz-broken
files...

Ronald


More information about the ffmpeg-devel mailing list