[FFmpeg-devel] [PATCH] libavformat/nutenc.c: Use ffv1 as default video encoder for NUT muxing

[Michael Niedermayer]

On Wed, Sep 27, 2017 at 07:14:50PM -0400, Leo Izen wrote:
> ---
>  libavformat/nutenc.c    |  2 +-
>  tests/ref/lavf/nut      |  6 +++---
>  tests/ref/seek/lavf-nut | 54 ++++++++++++++++++++++++-------------------------
>  3 files changed, 31 insertions(+), 31 deletions(-)
> 
> diff --git a/libavformat/nutenc.c b/libavformat/nutenc.c
> index a92ff55c01..6e96626ff0 100644
> --- a/libavformat/nutenc.c
> +++ b/libavformat/nutenc.c
> @@ -1221,7 +1221,7 @@ AVOutputFormat ff_nut_muxer = {
>      .priv_data_size = sizeof(NUTContext),
>      .audio_codec    = CONFIG_LIBVORBIS ? AV_CODEC_ID_VORBIS :
>                        CONFIG_LIBMP3LAME ? AV_CODEC_ID_MP3 : AV_CODEC_ID_MP2,
> -    .video_codec    = AV_CODEC_ID_MPEG4,
> +    .video_codec    = AV_CODEC_ID_FFV1,
>      .write_header   = nut_write_header,
>      .write_packet   = nut_write_packet,
>      .write_trailer  = nut_write_trailer,

Why?

also this breaks existing code and command lines which expect mpeg4 as
default

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20170928/d0642291/attachment.sig>