[FFmpeg-devel] [PATCH v3 1/3] avutil/log: rename and initialize global log flags variable

[Tobias Rapp]

On 29.03.2018 20:40, Michael Niedermayer wrote:
> On Wed, Mar 28, 2018 at 05:03:38PM +0200, Tobias Rapp wrote:
>> Rename global variable for symmetry with av_log_level.
>>
>> Signed-off-by: Tobias Rapp <t.rapp at noa-archive.com>
>> ---
>>   libavutil/log.c | 10 +++++-----
>>   1 file changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/libavutil/log.c b/libavutil/log.c
>> index 9b7d484..0a99d01 100644
>> --- a/libavutil/log.c
>> +++ b/libavutil/log.c
>> @@ -52,7 +52,7 @@ static AVMutex mutex = AV_MUTEX_INITIALIZER;
>>   #endif
>>   
>>   static int av_log_level = AV_LOG_INFO;
>> -static int flags;
>> +static int av_log_flags = 0;
> 
> This prefix is confusing as the av prefix is intended for
> exported public symbols which a static symbol cannot be

Stumbled over the generic name of this global variable when working on 
the av_log_set_opts function. As that patch is dropped I consider this 
patch as irrelevant.

Regards,
Tobias