[FFmpeg-devel] [PATCH 1/2] cbs_h265: Fix Time Code SEI syntax

Mark Thompson sw at jkqxz.net
Sun Dec 2 23:24:21 EET 2018


On 02/12/2018 20:51, Andreas Rheinhardt wrote:
> Mark Thompson:
>> On 01/12/2018 07:52, Andreas Rheinhardt wrote:
>>> Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt at googlemail.com>
>>> ---
>>> https://trac.ffmpeg.org/ticket/4141#comment:9 contains a sample
>>> containing Time Code SEI messages. Parsing it currently fails
>>> because counting_type is detected as out of range. Of course, it is not.
>>>
>>>  libavcodec/cbs_h265_syntax_template.c | 56 ++++++++++++++-------------
>>>  1 file changed, 30 insertions(+), 26 deletions(-)
>>
>> Oops.  Yep, applied.
>>
>> Do you happen to have a sample which could be included as a fate test?  Most of the other SEI messages are found in the standard conformance test suite and therefore get tested by it, but this one isn't.
>>
> As has already been said in the quoted section: Ticket 4141 contains
> such a sample. This is also the sample that made me investigate this.

Indeed, and I used it for testing.  However, it looks like a TV capture and it was uploaded by someone unknown, so I don't think I can infer anything about its copyright status for inclusion.  I've asked in the ticket.

Thanks,

- Mark


More information about the ffmpeg-devel mailing list