[FFmpeg-devel] [PATCH v2] lavfi/vf_colorconstancy: add weighted_greyedge

Mina minas.gorgy at gmail.com
Mon Dec 3 23:42:05 EET 2018


On 11/28/18 11:24 PM, Moritz Barsnick wrote:
> On Mon, Oct 01, 2018 at 18:09:46 +0200, Mina wrote:
>
> Nit:


Thanks for your feedback and sorry for late response.


>
>> +be chosen in the range [1,20] and default value is 1.
> [...]


Not sure what is here.


>> +chosen in the range [0.2,1024.0] and default value = 1.
> A bit inconsistent here, with "is" vs. "=".


Done, changed to "=".


>> +The max number of iterations for performing the algorithm. Must be chosen in the
>         ^ maximum


Done, changed to "maximum".


>
> I can't comment on the rest.
>
> Cheers,
> Moritz
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel


More information about the ffmpeg-devel mailing list