[FFmpeg-devel] [PATCH] libavcodec/fft_template: improve performance of the ff_fft_init in fft_template

[Carl Eugen Hoyos]

2018-12-17 15:56 GMT+01:00, Steven Liu <lq at chinaffmpeg.org>:
>
>
>> On Dec 17, 2018, at 22:05, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>>
>> 2018-12-17 10:13 GMT+01:00, Steven Liu <lq at chinaffmpeg.org>:
>>> After patch:
>>> init nbits = 17, get 10000 samples, duration: 15221
>>> Before patch:
>>> init nbits = 17, get 10000 samples, duration: 16105
>>>
>>> test script:
>>> DURATION=0
>>> for((i=0;i<10000;i++)) do
>>> ./libavcodec/tests/fft -n 17 &>output
>>> T_DURATION=`grep "duration" output | awk -F"=" '{ print $2}'`
>>> DURATION=`expr $DURATION + $T_DURATION`
>>> done
>>> TOTAL=`expr $DURATION / 10000`
>>> echo $TOTAL
>>
>> This script does not allow to reproduce afaict.
>> (There is no "duration" here in output)
>
> Do you mean i should commit 2/3 patch of the libavcodec/tests/fft.c modify?
> or just upload the modify diff here?

I believe your commit message should not contain a script
that cannot be used to reproduce your findings.

Carl Eugen