[FFmpeg-devel] [PATCH]lsws/utils: Split "emms_c(); " call in two lines

[Carl Eugen Hoyos]

2018-12-17 16:45 GMT+01:00, Nicolas George <george at nsup.org>:
> Carl Eugen Hoyos (2018-12-17):
>>  #ifndef emms_c
>> -#   define emms_c() while(0)
>> +#   define emms_c() while(0){}
>>  #endif
>
> That feels really wrong, or at least completely unusual. But not the
> change you made, the original code: the usual statement is:
> "do { statement } while (0)"
>
> And if you make that change, you will get a warning about a semicolon
> after a braced block.
>
> I suggest to change the definition to
>
> #define emms_c() do { } while (0)

New patch attached.

Thank you, Carl Eugen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-lavu-internal-Replace-an-empty-loop-with-do.patch
Type: text/x-patch
Size: 755 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20181217/6312cf4c/attachment.bin>