[FFmpeg-devel] [PATCH 1/2] avcodec: add photocd decoder

[Paul B Mahol]

On 12/21/18, Paul B Mahol <onemda at gmail.com> wrote:
> On 12/21/18, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>>
>>
>>> Am 21.12.2018 um 16:43 schrieb Paul B Mahol <onemda at gmail.com>:
>>>
>>>> On 12/21/18, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>>>> 2018-12-20 10:02 GMT+01:00, Paul B Mahol <onemda at gmail.com>:
>>>>>> On 12/20/18, Carl Eugen Hoyos <ceffmpeg at gmail.com> wrote:
>>>>>> 2018-12-19 21:32 GMT+01:00, Paul B Mahol <onemda at gmail.com>:
>>>>>>
>>>>>>> +static av_cold int photocd_decode_init(AVCodecContext *avctx)
>>>>>>> +{
>>>>>>> +    avctx->pix_fmt    = AV_PIX_FMT_YUV420P;
>>>>>>
>>>>>> I very much welcome this patch but it appears that the colourspace
>>>>>> conversion is missing that was part of the original patchset=-(
>>>>>
>>>>> Please refrain from telling me such obvious untrue things.
>>>>
>>>> I may misunderstand your comment, to clarify I attach a jpg
>>>> that shows FFmpeg output on top and reference output below
>>>> for the sample image IMG0024.PCD.
>>>
>>> I will ignore your comments as there is misunderstanding from your side.
>>
>> Would you like to clarify?
>
> The colors that PhotoCD uses predates color space definitions.
> There is no nice way to support it so only manual conversion could do it.
>

I will adjust U and V plane components, and leave Y untouched (result
will be acceptable to me).