[FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8/9 sharpness config option

[James Zern]

On Fri, Dec 21, 2018 at 11:24 AM James Almer <jamrial at gmail.com> wrote:
>
> On 12/21/2018 1:09 PM, James Zern wrote:
> > On Thu, Dec 20, 2018 at 7:51 PM Rene Claus
> > <rclaus-at-google.com at ffmpeg.org> wrote:
> >>
> >> This commit adds configuration options to libvpxenc.c that can be used to
> >> tune the sharpness parameter for VP8 and VP9.
> >>
> >> Signed-off-by: Rene Claus <rclaus at google.com>
> >> ---
> >>  doc/encoders.texi      | 4 ++++
> >>  libavcodec/libvpxenc.c | 6 ++++++
> >>  2 files changed, 10 insertions(+)
> >>
> >
> > This looks all right aside from the text comments.
> >
> >> diff --git a/doc/encoders.texi b/doc/encoders.texi
> >> index 3d5b9fc2d2..7f9478fa9d 100644
> >> --- a/doc/encoders.texi
> >> +++ b/doc/encoders.texi
> >> @@ -1767,6 +1767,10 @@ Set number of frames to look ahead for frametype and ratecontrol.
> >>  @item error-resilient
> >>  Enable error resiliency features.
> >>
> >> + at item sharpness @var{integer}
> >> +Codec control function to set higher sharpness at the expense of a lower PSNR.
> >> +The valid range is [0, 7]. Default is 0.
> >> +
> >
> > Codec control is meaningful for users of libvpx, but not here. The
> > text from vpxenc should work:
> > "Increase sharpness at the expense of lower PSNR"
> > The range is OK to keep, the default up to the library. From the
> > wrapper's point of view the default is unset.
> >
> >> [...]
> >> +    { "sharpness", "Sharpness", offsetof(VPxContext, sharpness), AV_OPT_TYPE_INT, {.i64 = -1}, -1, 7, VE},
> >>
> >
> > This could match as well:
> > "Increase sharpness at the expense of lower PSNR"
> >
> > No need to mention the range, that's handled automatically (try -h
> > encoder=libvpx).
>
> There's no need to mention it the AVOption description, but it's ok in
> the encoders.texi. Other options do it as well.
>

Yes that's what I meant, sorry if it wasn't clear.