[FFmpeg-devel] [PATCH v3] avcodec/libopus: support disabling phase inversion.

[Michael Niedermayer]

On Fri, Jan 26, 2018 at 11:30:57AM +0100, Menno de Gier wrote:
> From: Menno <mrdegier at gmail.com>
> 
> This supports disabling phase inversion in both the libopus encoder and the
> decoder.
> 
> Signed-off-by: Menno <mrdegier at gmail.com>
> ---
>  doc/encoders.texi       |  5 +++++
>  libavcodec/libopusdec.c | 33 +++++++++++++++++++++++++++++++++
>  libavcodec/libopusenc.c | 14 ++++++++++++++
>  3 files changed, 52 insertions(+)
[...]
> @@ -209,6 +223,24 @@ static void libopus_flush(AVCodecContext *avc)
>      avc->internal->skip_samples = opus->pre_skip;
>  }
>  
> +
> +#define OFFSET(x) offsetof(struct libopus_context, x)
> +#define FLAGS AV_OPT_FLAG_AUDIO_PARAM | AV_OPT_FLAG_DECODING_PARAM
> +static const AVOption libopusdec_options[] = {
> +#ifdef OPUS_SET_PHASE_INVERSION_DISABLED_REQUEST
> +    { "apply_phase_inv", "Apply intensity stereo phase inversion", OFFSET(apply_phase_inv), AV_OPT_TYPE_BOOL, { .i64 = 1 }, 0, 1, FLAGS },
> +    { NULL },
> +#endif
> +};

This crashes as it is missing the NULL element at the end

[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Why not whip the teacher when the pupil misbehaves? -- Diogenes of Sinope
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180201/19e21913/attachment.sig>