[FFmpeg-devel] [FFmpeg-cvslog] lavf: move fifo test muxer into separate file

Michael Niedermayer michael at niedermayer.cc
Wed Feb 7 04:52:52 EET 2018


On Tue, Feb 06, 2018 at 06:57:47PM +0000, Josh de Kock wrote:
> ffmpeg | branch: master | Josh de Kock <josh at itanimul.li> | Tue Jan  2 13:36:05 2018 +0000| [598d5f8579b3a048a643486a5f20fc4d479a2017] | committer: Josh de Kock
> 
> lavf: move fifo test muxer into separate file
> 
> This fixes the fate-fifo-muxer test with the clarified
> removal of registering external formats.
> 
> > http://git.videolan.org/gitweb.cgi/ffmpeg.git/?a=commit;h=598d5f8579b3a048a643486a5f20fc4d479a2017
> ---
> 
>  libavformat/Makefile           |   2 +-
>  libavformat/allformats.c       |   1 +
>  libavformat/fifo_test.c        | 151 +++++++++++++++++++++++++++++++++++++++++
>  libavformat/tests/fifo_muxer.c | 115 +------------------------------
>  4 files changed, 155 insertions(+), 114 deletions(-)

breaks build on linux arm qemu

LD	ffmpeg_g
libavformat/libavformat.a(allformats.o):(.rodata+0x74): undefined reference to `ff_fifo_test_muxer'
collect2: ld returned 1 exit status
make: *** [ffmpeg_g] Error 1


[...]
-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Rewriting code that is poorly written but fully understood is good.
Rewriting code that one doesnt understand is a sign that one is less smart
then the original author, trying to rewrite it will not make it better.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180207/5de0f8a8/attachment.sig>


More information about the ffmpeg-devel mailing list