[FFmpeg-devel] [PATCH 2/3] Add muxer/demuxer for raw codec2 and .c2 files

Carl Eugen Hoyos ceffmpeg at gmail.com
Fri Feb 9 12:29:19 EET 2018


2018-01-15 22:36 GMT+01:00 Tomas Härdin <tjoppen at acc.umu.se>:

>> +    if (p->buf[4] >  EXPECTED_CODEC2_MINOR_VERSION) score -=
>> AVPROBE_SCORE_MAX/5;
>> +    if (p->buf[5] >  AVPRIV_CODEC2_MODE_MAX)        score -=
>> AVPROBE_SCORE_MAX/5;
>> +    if (p->buf[6] != 0)                             score -=
>> AVPROBE_SCORE_MAX/5;
>> +    return score;
>>
>> Imo, this is too complicated:
>> If the first 32bit are correct, return MAX/2, for 24bit, return less

This should have been AVPROBE_SCORE_EXTENSION + 1,
sorry about my mistake.

Please threaten to push this and push after a few days.

Carl Eugen


More information about the ffmpeg-devel mailing list