[FFmpeg-devel] [PATCH]configure: Improve the wording of the license failure

Lou Logan lou at lrcd.com
Fri Feb 9 20:48:22 EET 2018


On Fri, Feb 9, 2018, at 1:06 AM, Carl Eugen Hoyos wrote:
> Hi!
> 
> It was reported on the user mailing list that "libvmaf is version3 and
> --enable-version3 is not specified." is unclear, attached patch tries
> to slightly improve the sentence.
> 
> Please comment, Carl Eugen
[...]

A few alternatives to consider:

> die_license_disabled() {
>-    enabled $1 || { enabled $v && die "$v is $1 and --enable-$1 is not specified."; }
>+    enabled $1 || { enabled $v && die "$v requires $1 for license reasons but --enable-$1 is not specified."; }

"$v requires --enable-$1." 
 
> die_license_disabled_gpl() {
>-    enabled $1 || { enabled $v && die "$v is incompatible with the gpl and --enable-$1 is not specified."; }
>+    enabled $1 || { enabled $v && die "$v is incompatible with the gpl but --enable-$1 is not specified."; }

"$v is incompatible with the GPL. --enable-$1 is required."
or
"$v is incompatible with --enable-gpl. --enable-$1 is required."
or
"$v is incompatible with the GPL. Add --enable-$1 or remove --enable-gpl."


More information about the ffmpeg-devel mailing list