[FFmpeg-devel] [PATCH] avformat/flvdec: Set broken_sizes for FlixEngine.

Michael Niedermayer michael at niedermayer.cc
Thu Feb 22 23:52:40 EET 2018


On Sat, Feb 17, 2018 at 02:06:20PM +0100, Tomas Härdin wrote:
> fre 2018-02-16 klockan 15:25 -0800 skrev Nikolas Bowe:
> > ---
> >  libavformat/flvdec.c | 4 +++-
> >  1 file changed, 3 insertions(+), 1 deletion(-)
> > 
> > diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c
> > index 0217cef842..b86451fcbf 100644
> > --- a/libavformat/flvdec.c
> > +++ b/libavformat/flvdec.c
> > @@ -598,7 +598,9 @@ static int amf_parse_object(AVFormatContext *s,
> > AVStream *astream,
> >                          if (version > 0 && version <= 655)
> >                              flv->broken_sizes = 1;
> >                      }
> > -                } else if (!strcmp(key, "metadatacreator") &&
> > !strcmp(str_val, "MEGA")) {
> > +                } else if (!strcmp(key, "metadatacreator")
> > +                    && (!strcmp(str_val, "MEGA")
> > +                        || !strncmp(str_val, "FlixEngine", 10))) {
> 
> Nit: please align the inner str(n)cmp:s

will fix the formating (ill actually split the if, it looks cleaner
as 2 ifs)
and will apply

thx


> 
> FlixEngine is the VP6 thing, right? Awful, awful tool. Patch probably
> OK though
> 
> /Tomas
> 
> _______________________________________________
> ffmpeg-devel mailing list
> ffmpeg-devel at ffmpeg.org
> http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

-- 
Michael     GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

It is dangerous to be right in matters on which the established authorities
are wrong. -- Voltaire
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: not available
URL: <http://ffmpeg.org/pipermail/ffmpeg-devel/attachments/20180222/e690e7ed/attachment.sig>


More information about the ffmpeg-devel mailing list