[FFmpeg-devel] [PATCH 3/4] lavfi/procamp_vaapi: fix the green output issue.

Carl Eugen Hoyos ceffmpeg at gmail.com
Wed Jan 24 01:52:35 EET 2018


2018-01-23 5:33 GMT+01:00 Jun Zhao <mypopydev at gmail.com>:

> -        procamp_params[i].type   = VAProcFilterColorBalance;

> +    procamp_params[i].type   = VAProcFilterColorBalance;

Please split this patch, so that functional change and re-indentation
of a large block do not happen in the same patch: This not only
makes reviewing easier, it also simplifies understanding the
patch at a later time.

While there, I suggest you post one patch to change the typos
in all files without non-typo changes.

Carl Eugen


More information about the ffmpeg-devel mailing list