[FFmpeg-devel] [PATCH V2 2/3] lavfi/procamp_vaapi: fix the green video issue if without arguments.

Carl Eugen Hoyos ceffmpeg at gmail.com
Fri Jan 26 01:36:28 EET 2018


2018-01-26 0:21 GMT+01:00 Mark Thompson <sw at jkqxz.net>:
> On 24/01/18 03:04, Jun Zhao wrote:
>>
>> From 1d3b388c313881e931928dc4049896265919725d Mon Sep 17 00:00:00 2001
>> From: Jun Zhao <jun.zhao at intel.com>
>> Date: Wed, 24 Jan 2018 09:28:24 +0800
>> Subject: [PATCH V2 2/3] lavfi/procamp_vaapi: fix the green video issue if
>>  without arguments.
>>
>> Fix the green output issue when use procamp_vaapi without any
>> arguments, now if use procamp_vaapi without any arguments, will use
>> the default value to setting procamp_vaapi.
>>
>> Signed-off-by: Jun Zhao <jun.zhao at intel.com>
>> ---
>>  libavfilter/vf_procamp_vaapi.c | 73 ++++++++++++++++++------------------------
>>  1 file changed, 31 insertions(+), 42 deletions(-)
>>
> On 24/01/18 03:04, Jun Zhao wrote:
>>
>> From 7a4a53fcc5a9b31b11818976dc02ea8e004d2c5a Mon Sep 17 00:00:00 2001
>> From: Jun Zhao <jun.zhao at intel.com>
>> Date: Wed, 24 Jan 2018 09:32:50 +0800
>> Subject: [PATCH V2 3/3] lavfi/misc_vaapi: use default value setting if without
>>  arguments.
>>
>> Signed-off-by: Jun Zhao <jun.zhao at intel.com>
>> ---
>>  libavfilter/vf_misc_vaapi.c | 64 +++++++++++++++++++++------------------------
>>  1 file changed, 30 insertions(+), 34 deletions(-)
>>
>
> Ah right, I didn't consider the same issue on the misc filters as well.  Always passing the arguments ends up being a bit simpler too, which is nice.
>
> Both LGTM, tested, applied.

So you prefer that nobody else comments on patches?

Carl Eugen


More information about the ffmpeg-devel mailing list