[FFmpeg-devel] avcodec/proresenc_aw improvements

Martin Vignali martin.vignali at gmail.com
Sun Jul 22 14:04:29 EEST 2018


>
> > 001 : use scantable in prores_data instead of a duplicate one.
>
> This could negativly affect the performance of the changed inner loop
> have you checked that the changed function does not become slower ?
>
>
>
No, i will make some tests.

> > -    *buf++ = 6;
> > +    *buf++ = pict->color_primaries;
> > +    *buf++ = pict->color_trc;
> > +    *buf++ = pict->colorspace;
>
> Has someone confirmed that all values our enum contains or will
> contain can just be written with no check ?
>
>
Mostly see prores with Rec709, Rec601. Need to take a look for Rec2020.
Don't know if all value are authorized, doesn't use other colorspace, with
prores.

Do you think it's better to only authorize few colorspace ?

Martin


More information about the ffmpeg-devel mailing list